Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tinyMCE for fixed html pages #3971

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Enable tinyMCE for fixed html pages #3971

merged 1 commit into from
Sep 27, 2024

Conversation

litvinovg
Copy link
Collaborator

VIVO GitHub issue

Vitro PR

What does this pull request do?

Enables TinyMCE editor for Fixed HTML field.

How should this be tested?

  • Create/Edit Fixed html pages, check result

Interested parties

@VIVO-project/vivo-committers

This was referenced Apr 4, 2024
Merged
Merged
@litvinovg litvinovg linked an issue Apr 4, 2024 that may be closed by this pull request
Fixed html pages editing should be supported with WYSYWIG editor #3963
Closed
@litvinovg litvinovg requested a review from chenejac April 4, 2024 12:34
chenejac
chenejac requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg it works well. The code is clear. I have only a complaint about user perspective of using this, not sure blue button Save this content is needed. If it can be hidden we can discuss that. Anyway, it is necessary that a user save complete page edit form, then the question is whether save this content inside rich edit field is needed.

@litvinovg
Copy link
Collaborator Author

@chenejac I think the button you wrote about exists in current main branch and is not part of this PR.
So I suggest to create a ticket to remove it if it is not needed.

@chenejac
Copy link
Contributor

@chenejac I think the button you wrote about exists in current main branch and is not part of this PR. So I suggest to create a ticket to remove it if it is not needed.

It looks to me as it is not useful at all. A user have to click on Save for the complete page, therefore I don't see the point of the Save this content button.

@chenejac chenejac requested a review from milospp April 12, 2024 11:03
@chenejac chenejac added this to the v1.15 milestone Jun 5, 2024
@chenejac chenejac modified the milestones: v1.15, v1.16 Jun 12, 2024
@litvinovg litvinovg force-pushed the wysywig-editor-fixed-html-pages branch from 27c9d7a to 1a6db26 Compare September 13, 2024 15:08
chenejac
chenejac approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg works for me. Thanks

@chenejac chenejac merged commit 09a745d into vivo-project:main Sep 27, 2024
4 checks passed
@chenejac chenejac removed this from the v1.16 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenejac chenejac chenejac approved these changes

@milospp milospp Awaiting requested review from milospp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed html pages editing should be supported with WYSYWIG editor
2 participants
@litvinovg @chenejac